-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos in conditon/sleeve_condition api comments #35
Comments
I'd suggest to add enummerations: Discogs.Condition = { Discogs.Status= { You might even want to wrap them in something from Hashie so that Discogs.Condition.mint would also work. |
I think adding a hash in for condition constants could be good. Want to add it and send a pull request? |
Hi Andrew, I need to learn first, how to make a push/pull I just monkey patched today, to get things working. me Monkey: require 'discogs' # force loading before patching
end Am 20.06.2014 um 01:08 schrieb Andrew Buntine notifications@github.com:
|
Typos in the api comments on the values for conditon and sleeve_condition:
Near Mint (NM or NM-) --> Near Mint (NM or M-)
Very Good Plus (VG)+ --> Very Good Plus (VG+)
Good Plus (G)+ --> Good Plus (G+)
The text was updated successfully, but these errors were encountered: