Add more possible Brew paths #39

buresdv · 2023-03-10T12:35:36Z

In some instances, the path to the brew command might be different, for example when Homebrew is installed through Git instead of their script. See https://elk.zone/glasgow.social/@sandy/109998976036176844

As the brew command is alsu used extensively, it would be a good idea to include it in AppConstants instead of having to write it out every time.

Proposed fix:

Add the path to the Brew command to AppConstants
Implement a system for checking which path is correct
Add an option to choose the location of Brew in settings, perhaps in the General tab

The text was updated successfully, but these errors were encountered:

jmb · 2023-03-10T13:53:24Z

FYI... This also applies to these lines in App Constants.swift:

    static let brewCellarPath: URL = URL(string: "/opt/homebrew/Cellar")!
    static let brewCaskPath: URL = URL(string: "/opt/homebrew/Caskroom")!

Hope this helps!

buresdv · 2023-03-10T15:11:39Z

What are those two paths for you? So I know

sandydunlop · 2023-03-10T15:13:42Z

For me they are: /usr/local/Cellar /usr/local/Caskroom

…

On Fri 10 Mar 2023 at 15:11, David Bureš ***@***.***> wrote: What are these two paths for you? So I know — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFN3QJYMCKKWOC5ZP7E5RD3W3NADPANCNFSM6AAAAAAVWNAVX4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

buresdv · 2023-03-10T15:45:01Z

@sandydunlop could you test the newest build from branch multiple-brew-paths?

@jmb, once @sandydunlop confirms that the fix is working, I will also implement it in your macOS 12 build.

jmb · 2023-03-10T15:45:59Z

Yes, also /usr/local

sandydunlop · 2023-03-10T15:55:04Z

I’ll be back at my computer in about 2 hours and will be able to check then. Had to go outside for a bit.

…

On Fri 10 Mar 2023 at 15:45, David Bureš ***@***.***> wrote: @sandydunlop <https://github.com/sandydunlop> could you test the newest build from branch multiple-brew-paths <https://github.com/buresdv/Cork/tree/multiple-brew-paths>? @jmb <https://github.com/jmb>, once @sandydunlop <https://github.com/sandydunlop> confirms that the fix is working, I will also implement it in your macOS 12 build. — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFN3QJ4I2XUV66BRWZN3NQ3W3NEATANCNFSM6AAAAAAVWNAVX4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

buresdv · 2023-03-10T15:55:54Z

Of course, no worries!

sandydunlop · 2023-03-10T19:36:11Z

This works for me, sorry for the delay. Thanks, Sandy

…

On 10 Mar 2023, at 15:56, David Bureš ***@***.***> wrote: Of course, no worries! — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFN3QJ74ALLXJ55GULODX6LW3NFJLANCNFSM6AAAAAAVWNAVX4>. You are receiving this because you were mentioned.

buresdv · 2023-03-10T19:37:23Z

Amazing, good to hear! I will merge it into main in that case.

@jmb I will update your macOS 12 build to implement this fix and then tell you when it's done

buresdv · 2023-03-10T20:16:54Z

@jmb Here's your macOS 12 version with the fix implemented. I have also implemented fixes for #20 and #38, which were not a part of your original build, but I wanted to fix them for you :)
Cork.zip

buresdv · 2023-03-10T20:17:59Z

The option for choosing your own paths is not implemented, perhaps in the future. This fix should cover all possible cases, unless the user does something batshit like moving the executable manually and not symlinking it.

sandydunlop · 2023-03-10T20:23:52Z

That sounds like the best way to do this. Totally agree that choosing arbitrary paths wouldn’t be the way to go. I can’t imagine there would be any other sensible paths. Thanks for the quick response on this :-)

…

On 10 Mar 2023, at 20:18, David Bureš ***@***.***> wrote: The option for choosing your own paths is not implemented, perhaps in the future. This fix should cover all possible cases, unless the user does something batshit like moving the executable manually and not symlinking it. — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFN3QJZVRL4HCCMJBLV5UKDW3OEAHANCNFSM6AAAAAAVWNAVX4>. You are receiving this because you were mentioned.

buresdv · 2023-03-10T20:24:59Z

No worries, and I thank you for your support :)

jmb · 2023-03-11T15:32:16Z

@jmb Here's your macOS 12 version with the fix implemented. I have also implemented fixes for #20 and #38, which were not a part of your original build, but I wanted to fix them for you :)
Cork.zip

Thank you this is amazing!

buresdv · 2023-03-17T15:41:10Z

Hey guys, could you please run brew tap-info homebrew/core and send me the output? I'm working on faster loading of Taps and I need to know where they are located for you, so this new system works for you
@jmb @sandydunlop

jmb · 2023-03-17T16:11:14Z

Here you go:

$ brew tap-info homebrew/core
homebrew/core: 3 commands, 6540 formulae
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core (6,995 files, 557.5MB)
From: https://github.com/Homebrew/homebrew-core

buresdv · 2023-03-18T13:34:44Z

@jmb could you test this build if all the tap features work?
Cork_LD.zip

@sandydunlop can you test this build, again if the taps load and the adding/removing of taps works?
Cork.zip

jmb · 2023-03-19T12:15:12Z

It's running ok, but I'm unsure what I need to test. If I click a tap in the left menu it doesn't show me any info, if I right-click kand choose "Remove", nothing happens.

When I click Update on the main screen to update my outdated packages, it says it's pulling updates, but also doesn't seem to do anything - the list remains. It does clear when I go and look at something else and come back.

buresdv · 2023-03-20T10:23:02Z

@jmb could you try running the branch lower-deployment-target from Xcode and seeing what errors it gives?

jmb · 2023-03-20T13:06:28Z

@jmb could you try running the branch lower-deployment-target from Xcode and seeing what errors it gives?

No major issues, the only minor error is [SwiftUI] No symbol named 'spigot' found in system symbol set.
👍🏻

jmb · 2023-03-20T13:07:50Z

buresdv · 2023-03-20T13:35:06Z

I will try to fix that missing icon 😅 Apart from the icon, everything else works? Namely the problem with the taps and updating

jmb · 2023-03-20T14:30:35Z

Updates all good. Taps don't seem to be left clickable - it would be handy to see the info about them. Looking at the console output in Xcode, I think it either needs to say what packages are installed that need removing first, or needs to ask if you want to remove those packages at the same time. Maybe a main panel screen with info about the tap would be helpful?

buresdv · 2023-03-20T15:45:51Z

Tap details are included in the main branch, but adding them came with a huge rewrite of the way Cork shows information, so I don't think I'll be able to backport that feature for you anymore.

I'll build the latest version of the app for you, but unfortunately, I think that will be as far as this backported version will ever go :(

buresdv · 2023-03-20T15:58:19Z

Here it is, I hope it will work:

Cork.zip

buresdv self-assigned this Mar 10, 2023

buresdv added Bug Something isn't working Enhancement New feature or request labels Mar 10, 2023

buresdv mentioned this issue Mar 10, 2023

Add keyboard shortcuts for searching #40

Closed

buresdv closed this as completed Mar 10, 2023

buresdv reopened this Mar 17, 2023

buresdv closed this as completed Mar 17, 2023

buresdv reopened this Mar 20, 2023

buresdv closed this as completed Mar 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more possible Brew paths #39

Add more possible Brew paths #39

buresdv commented Mar 10, 2023 •

edited

Loading

jmb commented Mar 10, 2023

buresdv commented Mar 10, 2023 •

edited

Loading

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023 •

edited

Loading

jmb commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

buresdv commented Mar 10, 2023

buresdv commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

jmb commented Mar 11, 2023

buresdv commented Mar 17, 2023

jmb commented Mar 17, 2023 •

edited

Loading

buresdv commented Mar 18, 2023 •

edited

Loading

jmb commented Mar 19, 2023 •

edited

Loading

buresdv commented Mar 20, 2023

jmb commented Mar 20, 2023

jmb commented Mar 20, 2023

buresdv commented Mar 20, 2023

jmb commented Mar 20, 2023

buresdv commented Mar 20, 2023 •

edited

Loading

buresdv commented Mar 20, 2023

Add more possible Brew paths #39

Add more possible Brew paths #39

Comments

buresdv commented Mar 10, 2023 • edited Loading

jmb commented Mar 10, 2023

buresdv commented Mar 10, 2023 • edited Loading

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023 • edited Loading

jmb commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

buresdv commented Mar 10, 2023

buresdv commented Mar 10, 2023

sandydunlop commented Mar 10, 2023 via email

buresdv commented Mar 10, 2023

jmb commented Mar 11, 2023

buresdv commented Mar 17, 2023

jmb commented Mar 17, 2023 • edited Loading

buresdv commented Mar 18, 2023 • edited Loading

jmb commented Mar 19, 2023 • edited Loading

buresdv commented Mar 20, 2023

jmb commented Mar 20, 2023

jmb commented Mar 20, 2023

buresdv commented Mar 20, 2023

jmb commented Mar 20, 2023

buresdv commented Mar 20, 2023 • edited Loading

buresdv commented Mar 20, 2023

buresdv commented Mar 10, 2023 •

edited

Loading

buresdv commented Mar 10, 2023 •

edited

Loading

buresdv commented Mar 10, 2023 •

edited

Loading

jmb commented Mar 17, 2023 •

edited

Loading

buresdv commented Mar 18, 2023 •

edited

Loading

jmb commented Mar 19, 2023 •

edited

Loading

buresdv commented Mar 20, 2023 •

edited

Loading