Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependency install part of the installation process does not get triggered #20

Closed
buresdv opened this issue Feb 25, 2023 · 3 comments
Assignees
Labels
Bug Something isn't working

Comments

@buresdv
Copy link
Owner

buresdv commented Feb 25, 2023

For some reason, this phase of the installation doesn't get triggered anymore. It used to, but now it just stopped.

Possible culprits

  • Checking if the dependency being currently installed is in the dependency array might not work properly
@buresdv buresdv self-assigned this Feb 25, 2023
@buresdv buresdv added the Bug Something isn't working label Feb 25, 2023
@buresdv
Copy link
Owner Author

buresdv commented Feb 26, 2023

It seems to be working now? It's weird

@buresdv
Copy link
Owner Author

buresdv commented Mar 10, 2023

The bug reappeared. Seems to be something to do with matching the correct output line

@buresdv
Copy link
Owner Author

buresdv commented Mar 11, 2023

It was because of the line that checked whether the line included "Fetching + (package name which was in the array of dependencies)"

In the old implementation, it was looking for "Fetching + (result of the check whether the package is included in the array of dependencies)", which would resolve to "Fetching true" or "Fetching false"

Changing the system to check for if "Fetching" and "true" are true at once fixed the problem.

@buresdv buresdv closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant