Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Keyboard Shortcuts #94

Closed
Jerry23011 opened this issue Apr 10, 2023 · 5 comments
Closed

Enhancement: Keyboard Shortcuts #94

Jerry23011 opened this issue Apr 10, 2023 · 5 comments
Labels
Enhancement New feature or request

Comments

@Jerry23011
Copy link
Collaborator

Just an idea, I noticed that Start Maintenance has the shortcut ⌘M, and macOS's default shortcut for ⌘M is minimize window. Also, Cork uses ⌘W & ⌘Q to quit the app. I'm thinking that maybe ⌘W could be used to close the window only.

@buresdv buresdv added the Enhancement New feature or request label Apr 10, 2023
@buresdv
Copy link
Owner

buresdv commented Apr 10, 2023

I didn't know about the ⌘M, because I have not heard anyone ever use it 😅 What other hotkey would you suggest for the maintenance feature?

Speaking of the ⌘W and ⌘Q, they both do the same thing because Cork closes itself completely after the window is closed. I'm following Apple's recommendations on this one, because Cork can only ever have one window open (it's not possible to open more than one window), so you're supposed to quit the app when the window closes. One solution I can think of would be to disable the ⌘W shortcut, what do you think about that?

@Jerry23011
Copy link
Collaborator Author

One solution I can think of would be to disable the ⌘W shortcut

In that case, I think sticking with the current one is better.

What other hotkey would you suggest for the maintenance feature?

Could be ⌥⌘M? Just like the one for adding a tap.

@buresdv
Copy link
Owner

buresdv commented Apr 10, 2023

Could be ⌥⌘M? Just like the one for adding a tap.

That hotkey is already used for Delete Cached Downloads though 🤔

@Jerry23011
Copy link
Collaborator Author

How about ⇧⌘M?

@buresdv
Copy link
Owner

buresdv commented Apr 10, 2023

I think that could work, I'll implement it

@buresdv buresdv closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants