Move replay action InterpretedKeyCommands from WebKit2 to WebCore #13
Labels
Milestone
Comments
burg
pushed a commit
that referenced
this issue
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=78454 Unreviewed. Rebaseline #13 of N. * platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png: * platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png: * platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png: * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png: Added. * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png: Added. * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: * platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Removed. * platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Removed. * platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png: * platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png: * platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
InterpretedKeyCommands needs to be located in WebCore, even though it is only used from WebKit2 code.
It will be a lot easier to deserialize all actions if they are defined in
WebCore,JavaScriptCore, orWTF. If not, there has to be some initialization code inWebKit/WebKit2---and these modules are otherwise not involved in Timelapse, aside from calling APIs with modified signatures.The text was updated successfully, but these errors were encountered: