Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-check existing uses of DeterminismLog for missing isActive() checks #47

Closed
burg opened this issue Sep 23, 2012 · 0 comments
Closed

Double-check existing uses of DeterminismLog for missing isActive() checks #47

burg opened this issue Sep 23, 2012 · 0 comments
Labels
I-wrong

Comments

@burg
Copy link
Owner

burg commented Sep 23, 2012

Per discussion at the end of Issue #41, we may be missing some checks as to whether the determinism log is currently "active". If not "active", then the script execution context was started by user actions we want to ignore, such as Inspector console commands.

The easiest way to check for this is to find all uses of DeterminismLog; main users will be memoized actions.
@burg burg mentioned this issue Sep 28, 2012
Closed
burg pushed a commit that referenced this issue Sep 28, 2012
Add some missing checks for DeterminismLog::isActive. Combine Determi…
afaac94 
…nismLog::activate,deactivate into setIsActive (per naming conventions). Fixes Issue #47.
@burg burg closed this as completed Sep 28, 2012
burg pushed a commit that referenced this issue Nov 6, 2012
@rjbailey
Add some missing checks for DeterminismLog::isActive. Combine Determi…
0da7f6d 
…nismLog::activate,deactivate into setIsActive (per naming conventions). Fixes Issue #47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@burg