Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NativeScript 5.0.0 and added support for Angular #17

Merged
merged 5 commits into from
Nov 26, 2018
Merged

Upgrade to NativeScript 5.0.0 and added support for Angular #17

merged 5 commits into from
Nov 26, 2018

Conversation

VladimirAmiorkov
Copy link

@VladimirAmiorkov VladimirAmiorkov commented Nov 23, 2018

This PR introduces:

  • Compatibility with NativeScript 5.0.0
  • Support for NativeScript Angular project
  • Compatibility with Ahead of Time Compilation of NativeScript Angular project
  • New Angular Demo for testing purposes
  • Refactored type definitions
  • New npm scripts for packing, publishing and running the repositories demos for easier plugin contribution

Related issues

#12

@bradmartin @burkeholland I would appreciate if you can take a look at this PR and if possible to merge and release a new version to npm.

VladimirAmiorkov added 5 commits November 23, 2018 11:32
chore: Refactored the way the plugin is packaged by adding npm and bash scripts and removed grunt tasks
chore: Updated the way the type definitions are exposed to avoid exposing entire namespace
chore: Bump to major new version
@tjvantoll tjvantoll merged commit 2d515f3 into burkeholland:master Nov 26, 2018
@tjvantoll
Copy link
Collaborator

Thanks @VladimirAmiorkov! This is now merged and published.

Just fyi npm run pack froze for me when copying the src folder, which was a bit odd. When I ran the pack and publish scripts manually though everything worked fine. No big deal, but I thought I’d note that for future reference.

@etabakov etabakov mentioned this pull request Nov 26, 2018
@VladimirAmiorkov
Copy link
Author

Hi @tjvantoll ,

Thank you. I will take a look at the npm run pack command I have not used it also so I will fix it.

@burkeholland
Copy link
Owner

Thanks, @VladimirAmiorkov!

I love that you all have kept this project going. It's literally my only contribution to humanity.

@VladimirAmiorkov
Copy link
Author

@burkeholland No problem, glad to have helped. I doubt that dude :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants