ci/Speed up typos checks #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 86.33% 86.54% +0.20%
==========================================
Files 469 469
Lines 44030 44191 +161
==========================================
+ Hits 38014 38244 +230
+ Misses 6016 5947 -69
☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Nov 2, 2023
kurnevsky
reviewed
Nov 3, 2023
| @@ -289,8 +290,18 @@ fn std_checks() { | |||
| } | |||
|
|
|||
| fn check_typos() { | |||
| // Install typos-cli | |||
| cargo_install(["typos-cli", "--version", "1.16.5"].into()); | |||
| // This path defines where typos-cl is installed on different | |||
There was a problem hiding this comment.
Ugh, you're right! eh eh
Can you open a new PR to fix the typo, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
This PR speeds up
typoschecks using the binary provided by a release and cachesxtaskandtyposbinariesTesting
Describe how these changes have been tested.