-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/Speed up typos checks #907
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 86.33% 86.54% +0.20%
==========================================
Files 469 469
Lines 44030 44191 +161
==========================================
+ Hits 38014 38244 +230
+ Misses 6016 5947 -69
☔ View full report in Codecov by Sentry. |
@@ -289,8 +290,18 @@ fn std_checks() { | |||
} | |||
|
|||
fn check_typos() { | |||
// Install typos-cli | |||
cargo_install(["typos-cli", "--version", "1.16.5"].into()); | |||
// This path defines where typos-cl is installed on different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos-cl
is a typo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, you're right! eh eh
Can you open a new PR to fix the typo, please?
Pull Request Template
Checklist
run-checks
script has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
This PR speeds up
typos
checks using the binary provided by a release and cachesxtask
andtypos
binariesTesting
Describe how these changes have been tested.