Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore jinja CVE #1481

Merged
merged 1 commit into from
Jun 13, 2024
Merged

ignore jinja CVE #1481

merged 1 commit into from
Jun 13, 2024

Conversation

lavigne958
Copy link
Collaborator

@lavigne958 lavigne958 commented Jun 13, 2024

fix CI by skiping unwanted CVE report.
fix CI by updating typing on google auth library

closes #1478

@lavigne958 lavigne958 requested a review from alifeee June 13, 2024 08:06
@lavigne958 lavigne958 self-assigned this Jun 13, 2024
closes #1478

Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
@lavigne958
Copy link
Collaborator Author

pushed force to update commit message

@alifeee
Copy link
Collaborator

alifeee commented Jun 13, 2024

is safety check worth using if we ignore it every time?

@lavigne958
Copy link
Collaborator Author

is safety check worth using if we ignore it every time?

it is for other matters, mostly for the google API we use, its current version being used and other potential libraries like requests etc.
for sure our use of it is very very limited and we could remove it, I'm fine with it.

May be let's find-out online what it really brings, and if we remove it what do we risk ? based on that we'll decide if we remove it

@lavigne958 lavigne958 merged commit ac9840f into master Jun 13, 2024
10 checks passed
@lavigne958 lavigne958 deleted the ci/ignore_jinja_cve branch June 13, 2024 13:05
@alifeee alifeee mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint failure
2 participants