Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Add an ability to set addition env via helm #399

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat(helm): Add an ability to set addition env via helm #399

merged 2 commits into from
Nov 21, 2023

Conversation

allanger
Copy link
Contributor

@allanger allanger commented Nov 20, 2023 •
edited
Loading 

Now it should be possible to set addition environment variables that are
going to be used by sql_exporter deployment.

User can either set a value of the variable, so it's taken directly from
Values, or use a value from an already existing Secret or ConfigMap.

Also, I've added bin to .helmignore and some auto-formatting has
happened to Values.yaml

Nikolai Rodionov added 2 commits November 20, 2023 13:18
feat: Add local bin dir to helmignore
b3c1331 
In case somebody wants to test the chart locally, after generating docs,
tests will fail, because helm will consider bin as a part of the chart,
and the size of the binary is too big to be installed to k8s
feat: Add an ability to set addition env via helm
6d17086 
Now it should be possible to set addition environment variables that are
going to be used by sql_exporter deployment.

User can either set a value of the variable, so it's taken directly from
Values, or use a value from an already existing Secret or ConfigMap.
@allanger allanger force-pushed the add-SQLEXPORTER_TARGET_DSN-supprt branch from 2c88708 to 6d17086 Compare November 20, 2023 12:29
@allanger allanger marked this pull request as ready for review November 20, 2023 12:34
@burningalchemist
Copy link
Owner

Thanks, I'll review it shortly. 👍

@allanger allanger mentioned this pull request Nov 20, 2023
Closed
burningalchemist
burningalchemist approved these changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@burningalchemist burningalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🚀

Once we support more env variables on the sql_exporter side, this change should work just fine. 👍

@burningalchemist burningalchemist changed the title feat: Add an ability to set addition env via helm feat(helm): Add an ability to set addition env via helm Nov 21, 2023
@burningalchemist burningalchemist merged commit bf66c18 into burningalchemist:master Nov 21, 2023
4 checks passed
@allanger allanger deleted the add-SQLEXPORTER_TARGET_DSN-supprt branch November 22, 2023 06:18
@allanger allanger mentioned this pull request Dec 11, 2023
Closed
@Marcel-Jansen Marcel-Jansen mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burningalchemist burningalchemist burningalchemist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanger @burningalchemist