If there is space in username, it doesn't work

[Blank-c]

What version of Garble and Go are you using?

$ garble version
v0.6.0

$ go version 
1.18.2

What environment are you running Garble on?

go env Output

$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Sauhard Gaming\AppData\Local\go-build
set GOENV=C:\Users\Sauhard Gaming\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\Sauhard Gaming\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\Sauhard Gaming\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.18.2
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\SAUHAR~1\AppData\Local\Temp\go-build2327819100=/tmp/go-build -gno-record-gcc-switches

What did you do?

garble build hello.go

What did you expect to see?

An executable file

What did you see instead?

[mvdan]

Hm, nicely spotted.

[mvdan]

The problem seems to be that -toolexec takes a space-separated list of arguments, so if the path to garble on disk contains a space, it splits that into two arguments. So in your case, -toolexec=/path/with spaces/to/garble tries to execute /path/with rather than /path/with spaces/to/garble.

The proper fix will need to be upstream, which is unfortunate as that could mean no backport to Go 1.18.x.

I'm trying to think if we could work around this. On Linux, we certainly could - if garble is running in /home/foo bar/go/bin/garble, we could have it copy the binary to /tmp/garble (via os.TempDir) and then use -toolexec=/tmp/garble to avoid the space. However, on Windows we can't do that - if garble is in C:\Users\foo bar\go\bin\garble, the only temporary directory will be something like C:\Users\foo bar\AppData\Local\Temp, which still contains a space. And I don't think there are any directories outside the user's home directory where we can reliably write executable files.

[mvdan]

Scratch that - there is no upstream bug. Fix incoming.