-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If there is space in username, it doesn't work #544
Comments
Hm, nicely spotted. |
The problem seems to be that The proper fix will need to be upstream, which is unfortunate as that could mean no backport to Go 1.18.x. I'm trying to think if we could work around this. On Linux, we certainly could - if |
Scratch that - there is no upstream bug. Fix incoming. |
If we don't quote it, paths containing spaces or quote characters will fail. For instance, the added test without the fix fails: > env NAME='with spaces' > mkdir $NAME > cp $EXEC_PATH $NAME/garble$exe > exec $NAME/garble$exe build main.go [stderr] go tool compile: fork/exec $WORK/with: no such file or directory exit status 1 Luckily, the fix is easy: we bundle Go's cmd/internal/quoted package, which implements a QuotedJoin API for this very purpose. Fixes burrowers#544.
If we don't quote it, paths containing spaces or quote characters will fail. For instance, the added test without the fix fails: > env NAME='with spaces' > mkdir $NAME > cp $EXEC_PATH $NAME/garble$exe > exec $NAME/garble$exe build main.go [stderr] go tool compile: fork/exec $WORK/with: no such file or directory exit status 1 Luckily, the fix is easy: we bundle Go's cmd/internal/quoted package, which implements a QuotedJoin API for this very purpose. Fixes burrowers#544.
If we don't quote it, paths containing spaces or quote characters will fail. For instance, the added test without the fix fails: > env NAME='with spaces' > mkdir $NAME > cp $EXEC_PATH $NAME/garble$exe > exec $NAME/garble$exe build main.go [stderr] go tool compile: fork/exec $WORK/with: no such file or directory exit status 1 Luckily, the fix is easy: we bundle Go's cmd/internal/quoted package, which implements a QuotedJoin API for this very purpose. Fixes burrowers#544.
If we don't quote it, paths containing spaces or quote characters will fail. For instance, the added test without the fix fails: > env NAME='with spaces' > mkdir $NAME > cp $EXEC_PATH $NAME/garble$exe > exec $NAME/garble$exe build main.go [stderr] go tool compile: fork/exec $WORK/with: no such file or directory exit status 1 Luckily, the fix is easy: we bundle Go's cmd/internal/quoted package, which implements a QuotedJoin API for this very purpose. Fixes #544.
What version of Garble and Go are you using?
What environment are you running Garble on?
go env
OutputWhat did you do?
What did you expect to see?
An executable file
What did you see instead?
The text was updated successfully, but these errors were encountered: