obfuscate syscall again to fix x/sys/unix #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating Garble to support Go 1.22.0, CI on MacOS spotted that the syscall package was failing to build given that it uses assembly code which is only allowed in some std packages. That allowlist is based on import paths, and we were obfuscating the syscall package's import path, so that was breaking GOOS=darwin. As a fix, I added syscall to runtimeAndDeps to not obfuscate it. That wasn't a great fix; it's not part of runtime and its dependencies, and there's no reason we should avoid obfuscating the package contents. Not obfuscating the contents in fact broke x/sys/unix, as it contains a copy of syscall.Rlimit which it type converted with. Undo that fix and reinstate the gogarble.txtar syscall test. Implement the fix where we only leave syscall's import path alone. Add a regression test, and add a note about adding x/net and x/sys to check-third-party.sh so that we can catch these bugs earlier. Fixes burrowers#830.
mvdan
force-pushed
the
obfuscate-syscall
branch
from
093bc4d
to
d6e83a0
Compare
|
I forgot that syscall.Rlimit is not declared on windows; the test should be fixed now. |
pagran
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #830.