parse url correctly #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBaczuk
requested changes
Apr 26, 2021
PlaidLink.tsx
Outdated
| const eventParams = queryString.parse(event.url) | ||
| const eventParams = queryString.parse( | ||
| event.url.replace( | ||
| /plaidlink:\/\/event|plaidlink:\/\/exit|plaidlink:\/\/connected/gi, |
There was a problem hiding this comment.
While this works, is this going to be a bit fragile? Like if they add something other than event, exit, or connected it will break. Can we just search for everything after and including the ??
There was a problem hiding this comment.
Good point. I updated to just replace everything up to and including the ?. I confirmed this works with queryString.
|
I'd love to see this merged, as it currently prevents this library from functioning. |
|
@defrex @udaraweerasinghege published as |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses : #6