Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default command to powershell if available #177

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 7, 2020

Set the command config to powershell or pwsh if available on install.

closes #128

@the-j0k3r
Copy link
Member

I wonder if its worth looking for the new Windows terminal

Also I assume you left out cmd prompt lookup since its going to be dropped in later Windows versions.

@UziTech
Copy link
Member Author

UziTech commented Oct 7, 2020

I think Windows terminal is more the GUI around the terminal process.

cmd is the default value so if powershell doesn't exist it falls back to that.

@UziTech UziTech changed the title default command to powershell if available feat: default command to powershell if available Oct 7, 2020
@UziTech UziTech merged commit 350d8c2 into master Oct 7, 2020
@UziTech UziTech deleted the powershell branch October 7, 2020 17:21
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released 📮 Release has been made
Development

Successfully merging this pull request may close these issues.

2 participants