Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bold button incorrectly reflects state #119

Closed
bantic opened this issue Sep 8, 2015 · 0 comments · Fixed by #120
Closed

bold button incorrectly reflects state #119

bantic opened this issue Sep 8, 2015 · 0 comments · Fixed by #120
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Sep 8, 2015

Sometimes, when the text that is highlighted is touching bold text, the button incorrectly reflects that the highlighted text is also bold.

To reproduce:

  • with text "hello world" in a section,
  • select "w" and make it bold
  • select the "o" after the "w"
  • the bold button will be shown as active (blue)
@bantic bantic self-assigned this Sep 8, 2015
bantic added a commit that referenced this issue Sep 8, 2015
@bantic
Fix bug in getting activeMarkers, use editor#markupsInSelection
1235d98 
fixes #119
@bantic bantic mentioned this issue Sep 8, 2015
Merged
bantic added a commit that referenced this issue Sep 9, 2015
@bantic
Fix bug in getting activeMarkers, use editor#markupsInSelection
0aec650 
 * cursor#moveToPosition and cursor#selectRange
 * rename applyMarkupToMarkers -> applyMarkupToRange
 * rename removeMarkupFromMarkers -> removeMarkupFromRange
 * Add Range#trimTo

fixes #119
bantic added a commit that referenced this issue Sep 9, 2015
@bantic
Fix bug in getting activeMarkers, use editor#markupsInSelection
0ed1d95 
 * cursor#moveToPosition and cursor#selectRange
 * rename applyMarkupToMarkers -> applyMarkupToRange
 * rename removeMarkupFromMarkers -> removeMarkupFromRange
 * Add Range#trimTo

fixes #119
bantic added a commit that referenced this issue Sep 9, 2015
@bantic
Fix bug in getting activeMarkers, use editor#markupsInSelection
4dbf261 
 * cursor#moveToPosition and cursor#selectRange
 * rename applyMarkupToMarkers -> applyMarkupToRange
 * rename removeMarkupFromMarkers -> removeMarkupFromRange
 * Add Range#trimTo

fixes #119
bantic added a commit that referenced this issue Sep 9, 2015
@bantic
Fix bug in getting activeMarkers, use editor#markupsInSelection
1c2fbab 
 * cursor#moveToPosition and cursor#selectRange
 * rename applyMarkupToMarkers -> applyMarkupToRange
 * rename removeMarkupFromMarkers -> removeMarkupFromRange
 * Add Range#trimTo

fixes #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in getting activeMarkers, use editor#markupsInSelection bustle/mobiledoc-kit
1 participant
@bantic