Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

un-exec toolbar button fails when selection starts with single-char marker #121

Closed
bantic opened this issue Sep 9, 2015 · 2 comments · Fixed by #122
Closed

un-exec toolbar button fails when selection starts with single-char marker #121

bantic opened this issue Sep 9, 2015 · 2 comments · Fixed by #122
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Sep 9, 2015

to reproduce:

  • create a section with text "abc"
  • make "b" bold
  • select "bc", bold button on toolbar should be active, click it to unbold the selection
  • the "b" in the selections does not get unbolded
@bantic bantic changed the title un-exec toolbar button fails when selection starts single-char marker un-exec toolbar button fails when selection starts with single-char marker Sep 9, 2015
@bantic bantic self-assigned this Sep 9, 2015
@mixonic
Copy link
Contributor

mixonic commented Sep 9, 2015

I believe the toolbar buttons should be going away entirely, and be supplanted by ember components in an addon.

@bantic
Copy link
Collaborator Author

bantic commented Sep 9, 2015

Yeah, this is a bug in the editor itself, it's just most easily reproduced using the toolbar.

bantic added a commit that referenced this issue Sep 9, 2015
@bantic
Use post#markersContainedByRange in postEditor#splitMarkers
63cb72a 
fixes #121
@bantic bantic mentioned this issue Sep 9, 2015
Merged
@vitosamson vitosamson mentioned this issue Nov 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use post#markersContainedByRange in postEditor#splitMarkers bustle/mobiledoc-kit
2 participants
@bantic @mixonic