Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cursorChanged event #157

Closed
bantic opened this issue Sep 21, 2015 · 0 comments · Fixed by #158
Closed

add cursorChanged event #157

bantic opened this issue Sep 21, 2015 · 0 comments · Fixed by #158
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Sep 21, 2015

This event will be useful in building a UI for content-kit that can react when the user moves the cursor through different markups, so that the UI can highlight a toolbar button corresponding to the current text under the cursor, for instance.
@bantic bantic self-assigned this Sep 21, 2015
bantic added a commit that referenced this issue Sep 21, 2015
@bantic
Fire event "cursorChanged" when cursor position changes
44334d8 
Fires after the selection changes as result of a mouseup or keyup event.

fixes #157
@bantic bantic mentioned this issue Sep 21, 2015
Merged
bantic added a commit that referenced this issue Sep 22, 2015
@bantic
Add cursorDidChange lifecycle callback to editor
d85760d 
fixes #157
bantic added a commit that referenced this issue Sep 22, 2015
@bantic
Add cursorDidChange lifecycle callback to editor
a50d0a1 
Remove editor#reportSelection and editor#reportNoSelection in favor
of funneling all selection-change-detection through
`editor#_reportSelectionState`

fixes #157
bantic added a commit that referenced this issue Sep 22, 2015
@bantic
Add cursorDidChange lifecycle callback to editor
cb20368 
Remove editor#reportSelection and editor#reportNoSelection in favor
of funneling all selection-change-detection through
`editor#_reportSelectionState`

fixes #157
bantic added a commit to mixonic/content-kit-editor that referenced this issue Sep 22, 2015
@bantic @mixonic
Add cursorDidChange lifecycle callback to editor
a16689c 
Remove editor#reportSelection and editor#reportNoSelection in favor
of funneling all selection-change-detection through
`editor#_reportSelectionState`

fixes bustle#157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bantic