Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleting characters outside the BMP does not work #274

Closed
bantic opened this issue Dec 17, 2015 · 0 comments · Fixed by #275
Closed

deleting characters outside the BMP does not work #274

bantic opened this issue Dec 17, 2015 · 0 comments · Fixed by #275
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Dec 17, 2015

Deleting characters outside the basic multilingual plane (like emoji, alchemical symbols and several others) does not work properly because they are composed of two code points. marker.deleteValueAtOffset naively splices out only a single "character" from the string.

emoji
@bantic bantic self-assigned this Dec 17, 2015
bantic added a commit that referenced this issue Dec 18, 2015
@bantic
marker#deleteValueAtOffset detects if the character is outside the BMP
ae1ab29 
fixes #274
@bantic bantic mentioned this issue Dec 18, 2015
Merged
2 tasks
bantic added a commit that referenced this issue Jan 6, 2016
@bantic
marker#deleteValueAtOffset detects if the character is outside the BMP
95098c9 
fixes #274
bantic added a commit that referenced this issue Jan 6, 2016
@bantic
marker#deleteValueAtOffset detects if the character is outside the BMP
2655232 
fixes #274
bantic added a commit that referenced this issue Jan 6, 2016
@bantic
marker#deleteValueAtOffset detects if the character is outside the BMP
f3b72ae 
fixes #274
mixonic pushed a commit to mixonic/content-kit-editor that referenced this issue Jan 22, 2016
@bantic @mixonic
marker#deleteValueAtOffset detects if the character is outside the BMP
ef57ad7 
fixes bustle#274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

marker#deleteValueAtOffset detects if the character is outside the BMP bustle/mobiledoc-kit
1 participant
@bantic