-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-browser testing on CI #326
Comments
Yeah I'd love help with this. SL integration just takes some time banging against configs to get right.
Indeed we support IE11. I would not say cross-brower contenteditable quirk-fixing is a "priority" though- In fact if Mobiledoc-Kit used canvas rendering instead of contenteditable that should just be an implementation quirk. But big 👍 for SL on IE11, Edge, FF, Safari, Chrome. Regressions are bugs. |
Cool, happy you're for it. I assume you'd want to keep the accounts under your control. Do you mind creating an account on https://saucelabs.com/beta/signup/OSS/None? I don't mind doing the configuration and stuff. |
@YoranBrondsema I've created the account. Feel free to ping me here or on gitter for more info. I'd be very happy to see SL integration going for mobiledoc-kit. |
@bantic Cool thanks. I'm still working on getting all tests to pass on IE11. As far as I could see there are two remaining "sets" of tests failing:
What do you prefer:
|
Thanks for looking into all of this, @YoranBrondsema. I think it makes the most sense to get SL up and running first, before all the tests are passing. |
Nice, I prefer 2 as well. Can you send me the SL info to my email address yoran@hstry.co? This way I can start setting it up. Thanks! |
Fix bug #326: Cross-browser testing on CI
One of the main goals of Mobiledoc-Kit is to provide cross-browser rich-text editing. With the latest releases, regressions have crept in on namely IE11. Currently, the builds on CI are performed on
phantomjs
only. However, I think that extending this to multiple browsers (or at least IE11) can prevent such regressions in the future.I was therefore wondering whether it makes sense to move to a cross-browser testing platform. I have no experience with them but I had a quick look and it looks like Sauce Labs could be interesting. Most interestingly, it is free for Open Source projects (see https://saucelabs.com/opensauce/).
This is just an idea but I think this project could really benefit from this, especially since its goal is to abstract all the cross-browser
contenteditable
quirks.The text was updated successfully, but these errors were encountered: