Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter at the start of a line/section has unexpected results #39

Closed
ErisDS opened this issue Aug 5, 2015 · 0 comments · Fixed by #53
Closed

Pressing enter at the start of a line/section has unexpected results #39

ErisDS opened this issue Aug 5, 2015 · 0 comments · Fixed by #53
Assignees

Comments

@ErisDS
Copy link
Contributor

ErisDS commented Aug 5, 2015

Placing the cursor at the start of a line and pressing enter causes the line to move down in 0.2.1. In 0.2.2 it at first appears to do nothing.

If, after having pressed enter at the beginning of a line, you move the cursor to somewhere else on the same line and also press enter, the content of the line is duplicated before the new line is added.

How I reproduced:

  • on master (58ffbc8) using broccoli serve to test the demo

Test 1:

  • Place the cursor at the beginning of the first line, press enter
  • nothing happens
  • Place the cursor anywhere except the beginning of the second line, press enter
  • the content of the line is duplicated and a new line is added

Test 2:

  • Place the cursor at the beginning of the first line, press enter
  • nothing happens
  • Place the cursor anywhere except the beginning of the second line, press enter
  • a new line is entered and no content is duplicated

Test 3:

  • Place the cursor at the beginning of the first line, press enter multiple times
  • Place the cursor at the beginning of the second line, press enter multiple times
  • Place the cursor anywhere except the beginning of a line, press enter
  • Content is duplicated on both lines!
@bantic bantic self-assigned this Aug 10, 2015
bantic added a commit that referenced this issue Aug 10, 2015
bantic added a commit that referenced this issue Aug 10, 2015
bantic added a commit that referenced this issue Aug 10, 2015
bantic added a commit that referenced this issue Aug 11, 2015
  * simplify section#splitMarker

fixes #39
bantic added a commit that referenced this issue Aug 11, 2015
  * simplify section#splitMarker
  * tests for hitting enter in middle and end of section
  * add test for hitting enter in first section
  * fix bug with PostNodeBuilder not assigning a builder to the blank marker

fixes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants