Document inputModeDidChange() lifecycle hook #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what happened that made the build fail? The log for the build on Travis is empty for me :/ |
|
OK, seems to an issue with |
|
Issue here: #557 |
|
@YoranBrondsema Thanks for this...I've kicked the Travis build. The repo rename from bustlelabs -> bustle seems like it might also have confused Travis. Here's the in-progress build: https://travis-ci.org/bustle/mobiledoc-kit/builds/226236041 |
|
@bantic Cool thanks! There are a few other small PRs that are ready for review :-) |
|
thanks @YoranBrondsema ! Rebuilding travis fixed the tests. :) |
|
released in v0.10.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook was not documented in the README and I believe it's important enough to have it there.