Add notification related endpoints and editorconfig #12
Conversation
|
|
||
| const router = express.Router(); | ||
|
|
||
| router.get('/', async (req, res) => { |
There was a problem hiding this comment.
I think receiving notifications with http transport is not used anymore, so we may not need this route. Can you confirm @jm90m ?
There was a problem hiding this comment.
If we are removing this, the validTokenMiddleware can be applied to the whole /notifications route.
|
I think what we miss is a way to send push notification to bSteem users when we stream them here: https://github.com/singhpratyush/busy-api/blob/3334b319b1e84fa190ab6e3ea8d099667852601c/server.js#L273 |
@bonustrack: I was planning to add it in further patches. But I can add it here if we want. |
singhpratyush
force-pushed
the
expo-registration
branch
3 times, most recently
from
17ab982
to
7226c93
Compare
|
I feel like if we want to merge it to master we should make it all in one PR, or we can create new branch and apply multiple PRs there. |
|
I'll add send notification hooks in this patch itself. |
- Use Authorization header for taking steemconnect access token - Use expo sdk to validate tokens - Return notifications at /notifications
singhpratyush
force-pushed
the
expo-registration
branch
2 times, most recently
from
34d11ac
to
a5a7761
Compare
|
@bonustrack @Sekhmet: I've added the code to send push notifications. Sorry for the delay. |
| @@ -0,0 +1,87 @@ | |||
| const Expo = require('expo-server-sdk'); | |||
There was a problem hiding this comment.
We use 2 spaces as the indentation. This file uses tabs. Can you update it?
There was a problem hiding this comment.
Sure. I'll also add an editorconfig.
helpers/expoNotifications.js
Outdated
| message = { | ||
| body: `${data.author} mentioned you in a ` + (data.is_root_post ? 'post.' : 'comment.'), | ||
| }; | ||
| break |
singhpratyush
force-pushed
the
expo-registration
branch
from
a5a7761
to
809f185
Compare
singhpratyush
changed the title
singhpratyush
force-pushed
the
expo-registration
branch
from
25ae017
to
da59d70
Compare
|
Yayy 🎉 |
Related: busyorg/busy#1872.