Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it want login access again when switching to desktop mode #1964

Closed
kr-nahid opened this issue Jun 12, 2018 · 1 comment
Closed

it want login access again when switching to desktop mode #1964

kr-nahid opened this issue Jun 12, 2018 · 1 comment

Comments

@kr-nahid
Copy link

Expected behavior

busy.org should not be want login access again when switching the view to desktop mode.

Actual behavior

when i logging in on busy.org , the website requests login access again when switching the view to desktop mode.

How to reproduce

  • go to the busy.org - https://busy.org/
  • Login with your steemit account.
  • After login, switch your browser mode to desktop mode, then the web will request login access again.

Browser/App version: Google Chrome ( 67.0.3396.68 Version)
Operating system: android 7.1.2 N2G47H

Recording Of The Bug

https://www.youtube.com/watch?v=Vca4Ot_MZhw

@th7nder
Copy link
Contributor

th7nder commented Feb 11, 2019

I've spent on this a couple hours. It seems to be a bug directly related to Google Chrome. To be precise, it's about internal handling of "Request desktop site" and only on Android implementation.

They assume, that when you use a website and it redirects you without any POST data it is a redirection like from "example.com" to "m.example.com". So that the original URL is "example.com" and when you click request desktop site button it redirects you back from m.example.com to the original URL.

In our case, when we log into busy.org it's done by SteemConnect's oAuth and then it redirects back to busy.org. So in Chrome's point of view it's like SC was the "example.com". When you click this request button directly after logging in it redirects you back to SC login site. The same happens with logging in via Google's oAuth at 9gag.com.

It doesn't happen if you did some actions after logging in - like viewing a post, checking out some user's profile or just refreshing a website.

One solution is to go to the SteemConnect, and ask them to make account selection a POST request, because of Chrome's implementation on Android.
Next one is to go to Chromium's bug tracker and tell them about it.
Last that I can think about is doing some trickery with redirections at busy's side.

https://github.com/chromium/chromium/blob/034ac8c45f13de5c647bcd5b20fad00b65b2aedd/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#L2247

https://github.com/chromium/chromium/blob/85aa920b45323e92e5d2dfb09ce61109c52147c9/content/browser/frame_host/navigation_controller_android.cc#L340

@Sekhmet Sekhmet closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants