New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SidebarWidgets #2013

Open

Sekhmet opened this issue Jun 26, 2018 · 0 comments

Labels

code quality refactor

Contributor

Sekhmet commented Jun 26, 2018 •

edited

Loading

Those components should use BaseWidget instead of reimplementing its logic. These components should be stateless.

CryptoTrendingCharts -> ChartsWidget
InterestingPeople and InterestingPeopleWithAPI -> PeopleWidget
LastDrafts -> LastDraftsWidget
PostRecommendation -> PostsWidget
ClaimRewardsBlock -> ClaimRewardsWidget
UserActivitySearch -> FilterWidget

Containers:

ChartsWidgetContainer for ChartsWidget
InterestingPeopleWidgetContainer and RebloggedPeopleWidgetContainer for ChartsWidget
LastDraftsWidgetContainer for LastDraftsWidget
PostRecommendationsWidgetContainer for PostsWidget
ClaimRewardsWidgetContainer for ClaimRewardsBlock
ActivityFilterWidgetContainer for FilterWidget

To be deleted:

LatestComments - not used
StartNow - not used

The text was updated successfully, but these errors were encountered:

Sekhmet added refactor code quality labels

Sekhmet self-assigned this

Sekhmet mentioned this issue

Add new sidebar widgets #2014

Closed

9 tasks

Sekhmet removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment