Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCM features should gate on OS and feature name #515

Closed
qdot opened this issue Nov 27, 2022 · 1 comment
Closed

DCM features should gate on OS and feature name #515

qdot opened this issue Nov 27, 2022 · 1 comment
Assignees
@qdot
Labels
bug Build Issues with the Build System/CI

Comments

@qdot
Copy link
Member

qdot commented Nov 27, 2022

Currently, DCMs are gated only by feature. However, they should gate with a combination of feature and target_os, which means we can use default feature sets for all platforms, ignore DCMs that won't build for certain platforms (i.e. no serial on android) and only retract DCM features if someone is using no_default_features.
@qdot qdot added bug Build Issues with the Build System/CI labels Nov 27, 2022
@qdot qdot self-assigned this Nov 27, 2022
@qdot qdot mentioned this issue Nov 27, 2022
Closed
@qdot
Copy link
Member Author

qdot commented Nov 29, 2022

Fixed in 6.2.2

@qdot qdot closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qdot qdot

Labels
bug Build Issues with the Build System/CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qdot