Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMQP client manager #9

Merged
merged 10 commits into from
Aug 18, 2020
Merged

Add AMQP client manager #9

merged 10 commits into from
Aug 18, 2020

Conversation

defgenx
Copy link
Contributor

@defgenx defgenx commented Aug 14, 2020

No description provided.

@defgenx defgenx self-assigned this Aug 14, 2020
AMQP testing file is hard to test. Take time to think of a better way to test or maybe change Manager implementation...
@buyco buyco deleted a comment from codecov-commenter Aug 14, 2020
@defgenx defgenx requested a review from ianarco August 17, 2020 08:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #9 into master will increase coverage by 3.75%.
The diff coverage is 43.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   40.00%   43.75%   +3.75%     
==========================================
  Files           4        5       +1     
  Lines         275      416     +141     
==========================================
+ Hits          110      182      +72     
- Misses        164      225      +61     
- Partials        1        9       +8     
Impacted Files Coverage Δ
pkg/client/aws.go 30.61% <0.00%> (ø)
pkg/client/redis.go 79.48% <ø> (ø)
pkg/client/sftp.go 29.66% <14.28%> (+0.45%) ⬆️
pkg/client/amqp.go 46.21% <46.21%> (ø)
pkg/client/pool.go 86.20% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae1468...9522857. Read the comment docs.

@defgenx defgenx merged commit 82bb94b into master Aug 18, 2020
@defgenx defgenx deleted the add-amqp-client-manager branch August 18, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants