-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant groups in sessionInfo: Remove ElecGp #305
Comments
I'm in favor of this. It existed only for backwards compatibility, but I don't think any current users are actually using it. |
👍
… On Mar 3, 2019, at 8:29 PM, David Tingley ***@***.***> wrote:
I'm in favor of this. It existed only for backwards compatibility, but I don't think any current users are actually using it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Could we use this opportunity to completely remove redundancy? Have everything pipe into SpikeGroups? (The only time this would be issue is if AnatGrps and SpkGrps conflict) |
I'm fine with this but that's a lot of work no? Could break lots of ppl's
code. I think you'd have to have buy in from users before doing this
…On Mon, Mar 4, 2019 at 12:25 PM Dan Levenstein ***@***.***> wrote:
Could we use this opportunity to completely remove redundancy? Have
everything pipe into SpikeGroups? (The only time this would be issue is if
AnatGrps and SpkGrps conflict)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#305 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTb6rmHTQx3IOqPjRtmE_M41jHic7ks5vTVcigaJpZM4ba8fG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to make some code that relates to sessionInfo. In there we have SpikeGroups, SpkGrps, AnatGrps, ElecGp. This is for back-compatability. However I think we can eliminate ElecGp: I searched in buzcode and found no uses of ElecGp outside of things that are reading xmls (ie nothing that actually uses it).
This would just be one small step and might prevent some future error where someone decides to use this old form of data - for no good reason. I also don't know what SPECIFICALLY ElecGp might signify different from the others
Think we should eliminate?
If not of course it's fine, but I would
The text was updated successfully, but these errors were encountered: