Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant groups in sessionInfo: Remove ElecGp #305

Open
brendonw1 opened this issue Mar 3, 2019 · 4 comments
Open

Redundant groups in sessionInfo: Remove ElecGp #305

brendonw1 opened this issue Mar 3, 2019 · 4 comments

Comments

@brendonw1
Copy link
Collaborator

I'm trying to make some code that relates to sessionInfo. In there we have SpikeGroups, SpkGrps, AnatGrps, ElecGp. This is for back-compatability. However I think we can eliminate ElecGp: I searched in buzcode and found no uses of ElecGp outside of things that are reading xmls (ie nothing that actually uses it).

This would just be one small step and might prevent some future error where someone decides to use this old form of data - for no good reason. I also don't know what SPECIFICALLY ElecGp might signify different from the others

Think we should eliminate?
If not of course it's fine, but I would

@DavidTingley
Copy link
Collaborator

I'm in favor of this. It existed only for backwards compatibility, but I don't think any current users are actually using it.

@dlevenstein
Copy link
Collaborator

dlevenstein commented Mar 4, 2019 via email

@dlevenstein
Copy link
Collaborator

Could we use this opportunity to completely remove redundancy? Have everything pipe into SpikeGroups? (The only time this would be issue is if AnatGrps and SpkGrps conflict)

@brendonw1
Copy link
Collaborator Author

brendonw1 commented Mar 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants