Slider window position

[Narrat]

Hi.
Any chance the slider popup will open in the direction with the most place available?
Currently it is placed under the icon which is kinda hindering when panels are placed on the bottom of the screen.

[buzz]

Yes, absolutely. The program should detect that I guess.
Do you bother to create a pull request?

[Narrat]

I'm currently looking at the tray.py to find out if I can help with it

[buzz]

The placing is happening here:
https://github.com/buzz/volctl/blob/master/volctl/tray.py#L207

The question is how to decide if the sliders should show above or below the icon. You could query the screen dimensions and if the icon is in the top half of the screen sliders go below otherwise above.

This way the most common cases (top/bottom panels) would be covered, right?

[Narrat]

At least the top/bottom panel users would be happy. Dunno about those, that place panels at the left or right.
Left would be less of an issue as with right placement, as the slider windows is appended to the right?

[buzz]

Yeah, they are probably more cases. Think of right-to-left script like Arabic.

But top/bottom panels would be awesome already ;)

[Narrat]

Didn't work that much with PyGI before. Is there a simple way to define in which direction the popup will open or can the size of the whole thing be calculated nicely?
Currently stuck at that point.
Hardcoded position values won't do it, as the size depends on font settings, gtk theme and so on (which is the next issue on the list :D If enough pa applications open, the slider menu will expand beyond the screen)

[Narrat]

Current WIP Narrat@709b146

Will take a look at the doc later. This magic value needs to vanish :D

[Narrat]

Cannot use get_size for the window, because it will return a default value as the window isn't visible. So it's reporting back 200x200 which is way to much for a correction.

Actual height for me is 165px. Your screen shows 155px.
If I don't hardcode the value I can "calculate" a value of 172px. Still hardcoded value in there (guess of icon size (16px)). Acceptable for me but not for everyone else :D

[buzz]

You are right: The window height is only available after calling window.show().

Could you test this, please?
https://github.com/buzz/volctl/tree/issue_7

[Narrat]

the issue_7 branch works for me :)

[ScuttleSE]

Reopening this.
I'm on a three monitor setup, and the slider-popups opens up almost in the middle of my middle monitor instead of on top of the tray icon, which is also on the middle screen.

My guess is that the program gets the resolution of my left or right monitor and uses that for the positioning instead of the middle one.

[buzz]

Reopening this.
I'm on a three monitor setup, and the slider-popups opens up almost in the middle of my middle monitor instead of on top of the tray icon, which is also on the middle screen.

My guess is that the program gets the resolution of my left or right monitor and uses that for the positioning instead of the middle one.

Opened #22 for this.