feat: Add unhighlightTag prop #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-startsev
requested changes
Apr 5, 2022
There was a problem hiding this comment.
@kaungmyatlwin Thanks for your contribution. I like the idea to have consistent highlight* and unhighlight* properties. Left a comment.
kaungmyatlwin
changed the title
|
Hi @sergei-startsev , thanks for replying. I've added two test cases f8d34a1 for Please have a look. |
sergei-startsev
requested changes
Apr 13, 2022
There was a problem hiding this comment.
@kaungmyatlwin please exclude package-lock.json, yarn.lock from the PR.
|
@sergei-startsev Rebased against master. Can you check? |
sergei-startsev
approved these changes
Apr 18, 2022
|
@kaungmyatlwin your changes will be included into the next release. |
|
@sergei-startsev Hi there! Would you mind creating a new release with this change? Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ability to render custom HTML tags / React Nodes instead of defaulting to
<span>element.Problem
Defaulting to
<span>is a good idea and must have, but sometimes we have edge cases where you need to pass custom React nodes in order to provide additional functionalities. Please see the Use Case below.Use Case
Should be able to render
<a>tags whenever necessary or pass React components (such as<Linkify>: https://github.com/tasti/react-linkify) to render the links properly.