-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If scrollbars are visible by default in OS horizontal scrollbar appears in vertical FixedSizeList #22
Comments
Adding width=100% to inner viewport partially solves the issue But just width:100% doesnt help if inner row has big uwrapable content like Adding |
I think the horizontal scrollbar should appear in this case. |
Do you mean non-mac users should work with ugly ui? |
Come on man, don't put ridiculous words in my mouth. @istarkov said that in the second case– if a row contained content that was too wide to fit within 100%, horizontal scrollbars would still appear. I said this should happen, because I know of some cases where people intentionally want a vertically windowed list to scroll horizontally. Edit I'm going to try the same fix I used for RV locally. Give me a bit. I just forgot this case. |
The fix will go out with 1.0.3 |
Fix has been deployed. You can verify it on the website. |
Thanks, Brian! |
No problem 😄 Thanks @istarkov for pointing out the oversight! |
If scrollbars are visible by default in OS horizontal scrollbar appears in vertical FixedSizeList at least in Chrome browser
How to reproduce
Set show scrollbars always
open
https://react-window.now.sh/#/examples/list/fixed-size
scroll a little bit down and you will see a horizontal scrollbar (scroll overflow is on scrollbar width)
The text was updated successfully, but these errors were encountered: