Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If scrollbars are visible by default in OS horizontal scrollbar appears in vertical FixedSizeList #22

Closed
istarkov opened this issue Jul 23, 2018 · 8 comments

Comments

@istarkov
Copy link
Contributor

istarkov commented Jul 23, 2018

If scrollbars are visible by default in OS horizontal scrollbar appears in vertical FixedSizeList at least in Chrome browser

image

How to reproduce
Set show scrollbars always
image

open
https://react-window.now.sh/#/examples/list/fixed-size

scroll a little bit down and you will see a horizontal scrollbar (scroll overflow is on scrollbar width)

@istarkov
Copy link
Contributor Author

istarkov commented Jul 23, 2018

Adding width=100% to inner viewport partially solves the issue

image

But just width:100% doesnt help if inner row has big uwrapable content like
here https://codesandbox.io/s/k56mm6301o (scrollbar appears again)

Adding position: "relative", on inner viewport solves an issue
https://codesandbox.io/s/vm5oow6j7l

@bvaughn
Copy link
Owner

bvaughn commented Jul 23, 2018

But just width:100% doesnt help if inner row has big uwrapable content like
here https://codesandbox.io/s/k56mm6301o (scrollbar appears again)

I think the horizontal scrollbar should appear in this case.

@TrySound
Copy link
Contributor

Do you mean non-mac users should work with ugly ui?

@bvaughn
Copy link
Owner

bvaughn commented Jul 23, 2018

Come on man, don't put ridiculous words in my mouth.

@istarkov said that in the second case– if a row contained content that was too wide to fit within 100%, horizontal scrollbars would still appear. I said this should happen, because I know of some cases where people intentionally want a vertically windowed list to scroll horizontally.

Edit I'm going to try the same fix I used for RV locally. Give me a bit. I just forgot this case.

bvaughn pushed a commit that referenced this issue Jul 23, 2018
@bvaughn
Copy link
Owner

bvaughn commented Jul 23, 2018

The fix will go out with 1.0.3

@bvaughn bvaughn closed this as completed Jul 23, 2018
@bvaughn
Copy link
Owner

bvaughn commented Jul 23, 2018

Fix has been deployed. You can verify it on the website.

@TrySound
Copy link
Contributor

Thanks, Brian!

@bvaughn
Copy link
Owner

bvaughn commented Jul 23, 2018

No problem 😄 Thanks @istarkov for pointing out the oversight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants