Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Fixnum deprecation warnings in ruby 2.4 #61

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Mar 2, 2017

In ruby 2.4, Fixnum and Bignum have been merged into a unified Integer class. In previous versions there should be no harm in treating them the same (both were Integer subclasses), so we might as well just check for Integer.

Fixes

versioncake-3.2.0/lib/versioncake/strategies/extraction_strategy.rb:8:
  warning: constant ::Fixnum is deprecated

In ruby 2.4, Fixnum and Bignum have been merged into a unified Integer
class. In previous versions there should be no harm in treating them the
same (both were Integer subclasses), so we might as well just check for
Integer.
@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8aed72c on jhawthorn:ruby_2_4_deprecation_warnings into 7c1d9d2 on bwillis:master.

@bwillis bwillis merged commit ec42701 into bwillis:master Mar 16, 2017
@bwillis
Copy link
Owner

bwillis commented Mar 16, 2017

Awesome looks good, thanks! 🌈

@joshhepworth
Copy link

Any estimate on when this will be available on rubygems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants