Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Big updates #11

Merged
merged 24 commits into from
Oct 21, 2021
Merged

Big updates #11

merged 24 commits into from
Oct 21, 2021

Conversation

bleleve
Copy link

@bleleve bleleve commented Oct 6, 2021

Hello,

This PR contains contains several updates as well as all previous PR not yet merged from ecolowtech :

  • update cert-manager to 1.5.4
  • update k8s API version to 0.22.2
  • migrate to new LiveDNS API (https://api.gandi.net)
  • add Helm repo with GitHub pages
  • simplify Dockerfile & switch to Buildx
  • update make test target (remove shell script)
  • update README.md with changes made
  • update GitHub workflow with Buildx
  • add k8s APF support (k8s >= 1.20)
  • add Helm chart-releaser in GitHub action

@bwolf You should activate GitHub Pages on an orphan gh-pages to activate helm charts, and create a v0.1.1 release before merging this PR (changes are detected compared to the previous release).

Best regards.

@bleleve bleleve marked this pull request as ready for review October 6, 2021 17:40
@bleleve bleleve closed this Oct 13, 2021
@bleleve bleleve deleted the big-updates branch October 13, 2021 14:31
@srgvg
Copy link

srgvg commented Oct 13, 2021

@bleleve too bad you had to close, but I had a hunch that would happen. Will you publish your version? Not sure what it takes to get here https://github.com/topics/cert-manager-webhook

@bleleve
Copy link
Author

bleleve commented Oct 13, 2021

@srgvg Sorry, I am still working on some improvements with GitHub actions (build, push and Helm release) and I had to delete the source branch or this PR. I will republish it after some tests ;)

@bleleve
Copy link
Author

bleleve commented Oct 14, 2021

@bwolf @srgvg PR reopened with new GitHub workflow (Docker image build and/or Helm chart release)

@bwolf bwolf self-assigned this Oct 17, 2021
@bwolf
Copy link
Owner

bwolf commented Oct 17, 2021

That looks awesome. Thanks for the PR. @bleleve What do you mean with "activate GitHub Pages on an orphan gh-pages to activate helm charts"? Especially "on an orphan". Do we need another repo for the gh-pages?

@bleleve
Copy link
Author

bleleve commented Oct 18, 2021

@bwolf Hi Marcus. The gh-branch needs to be detached from your repo history, you can create it with this commands:

git checkout --orphan gh-pages
git rm -rf .
git commit --allow-empty -m "Init GitHub Pages branch"
git push origin gh-pages

@bwolf
Copy link
Owner

bwolf commented Oct 21, 2021

I see with "on an orphan" you mean a branch (i.e. not a repo). I've not found the time to review it deeply, but overall it looks solid.

@bwolf bwolf merged commit e544607 into bwolf:master Oct 21, 2021
@bleleve
Copy link
Author

bleleve commented Oct 22, 2021

Hi @bwolf and thanks fort the merge.

I have seen that the GH workflow didn't work. You have manually created the v0.2.0-alpha release which is not the expected behavior. The "base" job checks for updated go & yaml files between the commit attached to the new tag and the previous release (this is why you had to create the first release manually). Once done, the "build" job is executed if go code was updated, and the "release" one if yaml files where too. The GH release is automatically created during the last job.

To fix this, delete the v0.2.0-alpha release and rerun the workflow. You can then modify the text of the release once it is published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants