Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instruction broken #84

Closed
bbros-dev opened this issue May 14, 2021 · 4 comments · Fixed by #86
Closed

Install instruction broken #84

bbros-dev opened this issue May 14, 2021 · 4 comments · Fixed by #86
Labels
bug Something isn't working

Comments

@bbros-dev
Copy link

bingo version output:

NA

go version output:

$ go version
go version go1.15.2 linux/amd64

What happened:

Followed the README.md instruction:

$ go get -u github.com/bwplotka/bingo                                                                   
go: downloading github.com/bwplotka/bingo v0.4.2                                                              
go: github.com/bwplotka/bingo upgrade => v0.4.2                                                               
go: downloading github.com/efficientgo/tools/core v0.0.0-20210201220623-8118984754c2                          
go: downloading github.com/Masterminds/semver v1.5.0                                                          
go: downloading github.com/oklog/run v1.1.0                                                                   
go: downloading github.com/mvdan/sh v1.3.0                                                                    
go: downloading golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898                                       
go: downloading github.com/mvdan/sh v1.3.1                                                                    
go: github.com/pkg/errors upgrade => v0.9.1                                                                   
go: golang.org/x/mod upgrade => v0.4.2                                                                        
go: golang.org/x/xerrors upgrade => v0.0.0-20200804184101-5ec99f83aff1                                        
go: github.com/efficientgo/tools/core upgrade => v0.0.0-20210326193628-425a09c04e05                           
go: github.com/mvdan/sh upgrade => v2.6.4+incompatible                                                        
go: downloading golang.org/x/mod v0.4.2
go: downloading github.com/efficientgo/tools/core v0.0.0-20210326193628-425a09c04e05
go: downloading github.com/mvdan/sh v2.6.4+incompatiblego: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: finding module for package mvdan.cc/sh/expandgo: finding module for package mvdan.cc/sh/syntax
go: downloading golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550go: downloading mvdan.cc/sh v1.3.1
go: downloading golang.org/x/sys v0.0.0-20190624142023-c5567b49c5d0go: downloading mvdan.cc/sh v2.6.4+incompatible
go: found mvdan.cc/sh/expand in mvdan.cc/sh v2.6.4+incompatible
go: found mvdan.cc/sh/syntax in mvdan.cc/sh v2.6.4+incompatiblego: golang.org/x/sys upgrade => v0.0.0-20210514084401-e8d321eab015
go: golang.org/x/sync upgrade => v0.0.0-20210220032951-036812b2e83c
go: golang.org/x/crypto upgrade => v0.0.0-20210513164829-c07d793c2f9a
go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
go: downloading golang.org/x/crypto v0.0.0-20210513164829-c07d793c2f9a
go: downloading golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1
go: downloading golang.org/x/sys v0.0.0-20210514084401-e8d321eab015
go: golang.org/x/term upgrade => v0.0.0-20210503060354-a79de5458b56
go: downloading golang.org/x/term v0.0.0-20210503060354-a79de5458b56
# github.com/bwplotka/bingo/pkg/envars
../../go/pkg/mod/github.com/bwplotka/bingo@v0.4.2/pkg/envars/eval.go:27:12: undefined: "github.com/mvdan/sh/sy
ntax".Parse
../../go/pkg/mod/github.com/bwplotka/bingo@v0.4.2/pkg/envars/eval.go:61:23: unknown field 'Context' in struct
literal of type interp.Runner
../../go/pkg/mod/github.com/bwplotka/bingo@v0.4.2/pkg/envars/eval.go:61:37: unknown field 'File' in struct lit
eral of type interp.Runner
../../go/pkg/mod/github.com/bwplotka/bingo@v0.4.2/pkg/envars/eval.go:61:46: cannot use envSlice (type []string
) as type expand.Environ in field value:
        []string does not implement expand.Environ (missing Each method)
../../go/pkg/mod/github.com/bwplotka/bingo@v0.4.2/pkg/envars/eval.go:62:18: not enough arguments in call to ru
.Run
        have ()
        want (context.Context, "mvdan.cc/sh/syntax".Node)

What you expected to happen:

Command to complete without error.

How to reproduce it (as minimally and precisely as possible):

As above

Logs (use bingo get -v <thing you do> for verbose output):

NA

Anything else we need to know:

Thank you for the effort you have put in to making bingo and for making it open source.

We are new to go, so perhaps have done something silly?

@rodcloutier
Copy link

FYI Started at version 0.4.1

@bwplotka
Copy link
Owner

Weird.... let me check. Thanks for reporting!

@bwplotka bwplotka added the bug Something isn't working label May 14, 2021
bwplotka added a commit that referenced this issue May 14, 2021
Fixes #84

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue May 14, 2021
Fixes #84

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue May 14, 2021
Fixes #84

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Owner

Should be fixed now: https://github.com/bwplotka/bingo/releases/tag/v0.4.3

@bbros-dev
Copy link
Author

Many thanks for the prompt fix. All now seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants