Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Check secondary storage before creating volume snapshots #1703

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Check secondary storage before creating volume snapshots #1703

merged 4 commits into from
Jan 16, 2020

Conversation

andrewbents
Copy link
Collaborator

closes #1478

storage

@coveralls
Copy link

coveralls commented Jan 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1919

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • 50 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 53.872%
Files with Coverage Reduction New Missed Lines %
src/app/vm/vm-sidebar/vm-detail/service-offering-details/service-offering-details.component.ts 5 57.69%
src/app/vm/container/service-offering-dialog.container.ts 14 48.89%
src/app/reducers/vm/redux/vm.effects.ts 31 90.41%
Totals Coverage Status
Change from base Build 1914: 0.1%
Covered Lines: 9831
Relevant Lines: 16218
💛 - Coveralls

wowshakhov
wowshakhov reviewed Jan 14, 2020
View reviewed changes
src/i18n/ru.json Outdated
@@ -123,6 +123,7 @@
},
"SNAPSHOT": {
"LIMIT_EXCEEDED": "Лимит снимков превышен. Для создания новых снимков Вам необходимо удалить какие-либо из ранее созданных снимков.",
"STORAGE_EXCEEDED": "Для создания снимка необходимо {{ required }} GiB диского пространства, но только {{ available }} GiB доступно в дополнительном хранилище.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

дискового

wowshakhov
wowshakhov suggested changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@wowshakhov wowshakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@bwsw
Copy link
Owner

bwsw commented Jan 15, 2020

@wowshakhov please review)

@bwsw bwsw merged commit af8be34 into bwsw:master Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pm-Egor-Genning pm-Egor-Genning pm-Egor-Genning approved these changes

@wowshakhov wowshakhov wowshakhov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amount of secondary storage available is not tracked when the user tries to take a snapshot
5 participants
@andrewbents @coveralls @bwsw @pm-Egor-Genning @wowshakhov