Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHPUnit 4/5 fallback #13

Closed
Zeromax opened this issue Feb 28, 2018 · 5 comments
Closed

Drop PHPUnit 4/5 fallback #13

Zeromax opened this issue Feb 28, 2018 · 5 comments

Comments

@Zeromax
Copy link

Zeromax commented Feb 28, 2018

Is it possible to drop the phpunit4 fallback?

if (!class_exists('\PHPUnit\Framework\TestCase')) {
    class_alias('\PHPUnit_Framework_TestCase', '\PHPUnit\Framework\TestCase');
}

I think there is no reason to keep this. PHPUnit 4 and 5 are no longer supported. see https://phpunit.de/

It would improve the auto completion for phpstorm a lot ;)

@byjg
Copy link
Owner

byjg commented Feb 28, 2018

Hi.

I also hate this fallback for PHPUnit, but since we support PHP5.6 I have to maintain this fallback OR drop the support for PHP 5.6 also;

Unfortunately I cannot drop the support for PHP 5.6 at this moment, but I am open for discuss alternatives to solve this problem. If you have some idea will be welcome.

Major Version PHP Compatibility Initial Release Support
PHPUnit 8 PHP 7.2, PHP 7.3, PHP 7.4 February 1, 2019 Support ends on February 5, 2021
PHPUnit 7 PHP 7.1, PHP 7.2, PHP 7.3 February 2, 2018 Support ends on February 7, 2020
PHPUnit 6 PHP 7.0, PHP 7.1, PHP 7.2 February 3, 2017 Support ends on February 1, 2019
PHPUnit 5 PHP 5.6, PHP 7.0, PHP 7.1 October 2, 2015 Support ended on February 2, 2018

@Zeromax
Copy link
Author

Zeromax commented Mar 1, 2018

Hi,

thanks for your answer. Ok, I get your point.
maybe it is possible to drop phpunit 4 only and increase to phpunit 5.4.

Cause this is the version when they introduced the \PHPUnit\Framework\TestCase class.
https://phpunit.de/manual/5.4/en/writing-tests-for-phpunit.html

less then 5.4 needs this fallback:
https://phpunit.de/manual/5.3/en/writing-tests-for-phpunit.html

Is this a possibility? So we can keep php 5.6 and remove the fallback.

byjg added a commit that referenced this issue Mar 1, 2018
@byjg
Copy link
Owner

byjg commented Mar 1, 2018

Yeah, I see PHPUnit 5.* offers support to PHP 5.6, 7.0 and 7.1. The support for PHPUnit 5.3, 5.4 is no longer necessary.

I created a branch issue-13 for that.

@Zeromax
Copy link
Author

Zeromax commented Mar 1, 2018

Perfect. Thank you.

byjg added a commit that referenced this issue Mar 1, 2018
Adjusts to support issue #13
@byjg
Copy link
Owner

byjg commented Mar 1, 2018

Added the Release "1.2.4"

@byjg byjg closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants