Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxr does not build with ghc-9.0 due to HaXml #30

Closed
juhp opened this issue Jul 2, 2021 · 14 comments
Closed

haxr does not build with ghc-9.0 due to HaXml #30

juhp opened this issue Jul 2, 2021 · 14 comments

Comments

@juhp
Copy link
Contributor

juhp commented Jul 2, 2021

Unfortunately HaXml does not build yet with ghc-9.0: hackage-trustees/malcolm-wallace-universe#11.
I actually only need it for haxr... I was told to make my own fork if I want to upload a fixed HaXml...

Just wondering what is the best approach here in terms of maintenance. Any thoughts or suggestions?

@byorgey
Copy link
Owner

byorgey commented Jul 2, 2021

Hmm, good question. Let's see if @phadej replies to that ticket, I'm not sure I understand the objection.

@byorgey
Copy link
Owner

byorgey commented Jul 2, 2021

Out of curiosity, what exactly did you have to change to get it to build with GHC-9.0? I don't seem to see any relevant changes in that PR you linked.

@juhp
Copy link
Contributor Author

juhp commented Jul 3, 2021

Ah, the changes are in the preceding commits (not mine), but there was no Hackage upload... 🤦
So this was just an attempt to prepare a release for that.

@juhp
Copy link
Contributor Author

juhp commented Jul 3, 2021

I believe it is this change that requires a new release rather than a revision alas.

@byorgey
Copy link
Owner

byorgey commented Jul 3, 2021

Just for future reference, I found the relevant discussion here: hackage-trustees/malcolm-wallace-universe#9 . Maybe it would be easiest just to set up your own fork. I'd be happy to help maintain it as well if you give me access.

@juhp
Copy link
Contributor Author

juhp commented Jul 4, 2021

Yes, nod, but how to do the import is my main stumbling block?
Do we just fork malcolm-wallace-universe (probably confusing), or try to create a fresh git repo eg by importing Hackage releases, or just drop all history and start from current HEAD?

@juhp
Copy link
Contributor Author

juhp commented Sep 23, 2021

Okay Malcolm added me as a Hackage maintainer of HaXml this week: so I should be able to upload a new version soon.
I am just wondering whether to make a HaXml org or even malcolm-wallace-universe (though probably not -
my intention is just to help keep HaXml afloat as long as needed and possible). I hope you can join me (and others) there. :-)

@byorgey
Copy link
Owner

byorgey commented Sep 24, 2021

Re: what kind of org to make, if your intention is to just support HaXml, then better keep it to that for now! I will definitely join you there, ping me or post a link here!

@juhp
Copy link
Contributor Author

juhp commented Sep 25, 2021

Sure thing, thanks

@juhp
Copy link
Contributor Author

juhp commented Sep 26, 2021

@juhp
Copy link
Contributor Author

juhp commented Sep 27, 2021

I have released HaXml-1.25.6 on Hackage

Hopefully it can go into Stackage Nightly soon

@juhp juhp closed this as completed Sep 27, 2021
@juhp
Copy link
Contributor Author

juhp commented Sep 29, 2021

Well maybe I closed prematurely, but I see you already enabled 9.0, thanks.
So can we have a new release soon? :-)

@byorgey
Copy link
Owner

byorgey commented Sep 29, 2021

The latest release of haxr has now been revised on Hackage to build with GHC 9.0!

@juhp
Copy link
Contributor Author

juhp commented Sep 30, 2021

Yay, thanks!

juhp added a commit to commercialhaskell/stackage that referenced this issue Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants