-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(rumqttd/architecture): added ontology description and feature description #635
Conversation
…scription Enhanced the description of the current architecture of `rumqttd`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Everything is explained quite nicely. 💯
Also wdyt about adding diagrams? All this much info can be very hard to keep in mind. Adding diagrams might help to understand it quickly. Doesn't have to be fancy just something that can describe how things link together. for e.g. below diagram shows relation between |
I'd like to add Diagrams. This one you've mentioned can be one, A few other ones I can think of right now are
|
I was going to suggest something like a state transaction diagram & sequence diagram, but it will get covered by the flow of a packet. So imo diagrams you mentioned should be good enough. I think we can merge this PR and add diagrams later. That way, others can start referring to these cool docs, wdyt @henil ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge if open comments are resolved.
All open comments have been resolved! |
…scription (bytebeamio#635) * docs(rumqttd/architecture): added ontology description and feature description Enhanced the description of the current architecture of `rumqttd` * docs(rumqttd/architecture): made docs more specific * docs(rumqttd/architecture) clarified router start semantics * docs(rumqttd/architecture): clarified link specifics and datapath
Enhanced the description of the current architecture of
rumqttd
Type of change
Miscellaneous (related to maintanance)
Checklist:
cargo fmt
CHANGELOG.md
if its relevant of user of the library. If its not relevant mention why.This isn't relevant as it's a documentation change.