Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rumqttd/architecture): added ontology description and feature description #635

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

anirudhRowjee
Copy link
Contributor

Enhanced the description of the current architecture of rumqttd

Type of change

Miscellaneous (related to maintanance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

This isn't relevant as it's a documentation change.

…scription

Enhanced the description of the current architecture of `rumqttd`
@anirudhRowjee anirudhRowjee requested a review from h3nill June 7, 2023 14:18
@swanandx swanandx self-requested a review June 9, 2023 15:49
Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Everything is explained quite nicely. 💯

rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
@swanandx swanandx removed the request for review from h3nill June 10, 2023 16:37
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
rumqttd/architecture.md Outdated Show resolved Hide resolved
@h3nill
Copy link

h3nill commented Jun 17, 2023

Also wdyt about adding diagrams?

All this much info can be very hard to keep in mind. Adding diagrams might help to understand it quickly. Doesn't have to be fancy just something that can describe how things link together.

for e.g. below diagram shows relation between Server (and runtime running on that thread which contains RemoteLinks) and Router:

image

@anirudhRowjee
Copy link
Contributor Author

I'd like to add Diagrams. This one you've mentioned can be one, A few other ones I can think of right now are

  1. The component diagram
  2. The flow of a single network packet through the system
    Any other suggestions?

@swanandx
Copy link
Member

Any other suggestions?

I was going to suggest something like a state transaction diagram & sequence diagram, but it will get covered by the flow of a packet. So imo diagrams you mentioned should be good enough.

I think we can merge this PR and add diagrams later. That way, others can start referring to these cool docs, wdyt @henil ?

Copy link

@h3nill h3nill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge if open comments are resolved.

@anirudhRowjee
Copy link
Contributor Author

All open comments have been resolved!

@anirudhRowjee anirudhRowjee merged commit 72007ef into main Jun 28, 2023
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
…scription (bytebeamio#635)

* docs(rumqttd/architecture): added ontology description and feature description

Enhanced the description of the current architecture of `rumqttd`

* docs(rumqttd/architecture): made docs more specific

* docs(rumqttd/architecture) clarified router start semantics

* docs(rumqttd/architecture): clarified link specifics and datapath
@swanandx swanandx deleted the docs-rumqttd-arch-v2 branch February 23, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants