Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional client certificates while using native-tls #758

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

swanandx
Copy link
Member

client certificate is optional while using rumqttc with rustls. But with native-tls, it is required to specify certificates!

Client authentication certificates should be optional for native-tls as well, this PR makes the required changes for it 🚀

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@swanandx swanandx requested a review from de-sh November 26, 2023 17:51
Copy link
Contributor

@de-sh de-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@swanandx swanandx merged commit 22d7fae into main Nov 27, 2023
3 checks passed
@swanandx swanandx deleted the optional-client-auth branch November 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants