Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Packet::size for v4/v5 #817

Merged
merged 2 commits into from
Mar 16, 2024
Merged

feat: implement Packet::size for v4/v5 #817

merged 2 commits into from
Mar 16, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Mar 11, 2024

Type of change

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@de-sh de-sh marked this pull request as draft March 11, 2024 06:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8228536494

Details

  • 0 of 58 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on size at 37.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/mqttbytes/v4/connack.rs 0 6 0.0%
rumqttc/src/mqttbytes/v4/connect.rs 0 6 0.0%
rumqttc/src/v5/mqttbytes/v5/connect.rs 0 6 0.0%
rumqttc/src/v5/mqttbytes/v5/ping.rs 0 6 0.0%
rumqttc/src/mqttbytes/v4/mod.rs 0 17 0.0%
rumqttc/src/v5/mqttbytes/v5/mod.rs 0 17 0.0%
Totals Coverage Status
Change from base Build 8150861145: 37.7%
Covered Lines: 6255
Relevant Lines: 16592

💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review March 16, 2024 12:29
@de-sh de-sh changed the base branch from main to codec March 16, 2024 14:44
@de-sh de-sh merged commit 719633a into codec Mar 16, 2024
4 checks passed
@de-sh de-sh deleted the size branch March 16, 2024 14:44
de-sh added a commit that referenced this pull request Mar 24, 2024
* refactor: implement size for all v5 packet types

* refactor: implement `Packet.size()` for v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants