fix unresolved symbol issue when using latest Rust nightly
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this writing, recent Rust `nightly` builds include a version of the `libc` crate that expects `wasi-libc` to define the following global variables, but `wasi-libc` defines them as preprocessor constants which aren't visible at link time, so we need to define them somewhere. Ideally, we should fix this upstream, but for now we work around it. This commit also addresses an unused field warning. Fixes #86 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this writing, recent Rust
nightlybuilds include a version of thelibccrate that expectswasi-libcto define the following global variables, butwasi-libcdefines them as preprocessor constants which aren't visible at link time, so we need to define them somewhere. Ideally, we should fix this upstream, but for now we work around it.This commit also addresses an unused field warning.
Fixes #86