Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose JS_DupValueExt #609

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Expose JS_DupValueExt #609

merged 1 commit into from
Feb 27, 2024

Conversation

saulecabrera
Copy link
Member

@saulecabrera saulecabrera commented Feb 27, 2024 •
edited
Loading

This commit exposes an API to access JS_DupValue.

Closes #607

I also formatted a bit the value.c file.

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@saulecabrera saulecabrera mentioned this pull request Feb 27, 2024
Closed
@saulecabrera saulecabrera force-pushed the js-dup-value-ext branch 3 times, most recently from 4266937 to b7d4569 Compare February 27, 2024 13:52
@saulecabrera
Expose JS_DupValueExt
f591e7a 
This commit exposes an API to access `JS_DupValue`.

This commit also formats `value.c`

Closes bytecodealliance#607

Fix incorrect use of `JSValueConst`
surma
surma approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@surma surma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the quick fix on this :D

@saulecabrera saulecabrera merged commit 0adeff6 into bytecodealliance:main Feb 27, 2024
14 checks passed
@saulecabrera saulecabrera deleted the js-dup-value-ext branch February 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surma surma surma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[quickjs-wasm-sys] JS_DupValue is missing
2 participants
@saulecabrera @surma