This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Fix benchmarks #60
Merged
Fix benchmarks #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2019 15:10
the symbol LUCET_WASM_PAGE_SIZE couldnt be resolved from the benchmarking suite. Rather than figure out the "right" way to solve this, I moved it to preprocessor since it should never change, and all-caps C identifiers are generally assumed to be resolved by the preprocessor.
i guess clang was happy to do it via filename, but gcc wasnt
ghost
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC linker works a bit differently than Clang, so these makefile changes fix it