image2tensor supports planar format output. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
approved these changes
Jan 13, 2024
|
cc: @geekbeast |
|
I guess one of us should try to fix CI; @jianjunz, we can talk about this more next week. The current job is a bit of a scripted monolith that we might need to refactor. But then again, it's not too useful to spend a lot of time on this since the bindings portion of this could be replaced by |
|
Thanks for your review. Please help merge if it looks good. The CI failure is caused by openvino checksum mismatch. It may need an update. |
|
A bit late, but this looks good to me. |
guptaaryan16
pushed a commit
to guptaaryan16/wasi-nn-mlx
that referenced
this pull request
Jun 10, 2024
* image2tensor supports planar format output. * Add enum MemoryLayout for planar output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mainly adds support for outputting tensor bytes in planar memory layout, or CHW format. Besides this, it also adds support for png input with alpha channel (output still doesn't have alpha channel, so it's stripped out).