Update Rust gen to use .wit spec #97
Conversation
This commit updates the regeneration script for the Rust bindings to use `wasi-nn.wit` types instead of `wasi-nn.witx`. The scripts has also been run and the bindings (src/generated.rs) have been updated. This example currently compiles but fails at runtime because the version of the wasi-nn spec that wasmtime is using is not the latest. Once it has been updated this example should work (I've tested it with the version that wasmtime is currently on and it works but that requires changes to the examples in this repository). Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
|
@danbev, thanks for this PR and apologies for not looking at it sooner. The reason is that I'm actually working on this at the moment (e.g., bytecodealliance/wasmtime#8519) and have been thinking: once users fully switch to using WIT for the interface, is there a need to keep the |
@abrown No worries at all!
I see your point and that is an option. I just found that having this crate simplified the code in the project I was working on. But it is not a big deal to handle and if it means not having to maintain this repo I understand the value in that. So both ways work for me 👍 |
This commit updates the regeneration script for the Rust bindings to use
wasi-nn.wittypes instead ofwasi-nn.witx.The scripts has also been run and the bindings (src/generated.rs) have been updated.
This example currently compiles but fails at runtime because the version of the wasi-nn spec that wasmtime is using is not the latest. Once it has been updated this example should work (I've tested it with the version that wasmtime is currently on and it works but that requires changes to the examples in this repository).