Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set gc reclaim in wasm_exec_env_create #2043

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

yviansu
Copy link

@yviansu yviansu commented Mar 21, 2023

No description provided.

@@ -154,6 +163,9 @@ wasm_exec_env_create(struct WASMModuleInstanceCommon *module_inst,
exec_env->aux_stack_bottom.bottom = module->aux_stack_bottom;
exec_env->aux_stack_boundary.boundary =
module->aux_stack_bottom - module->aux_stack_size;
#if WASM_ENABLE_GC != 0
gc_heap_handle = ((AOTModuleInstance *)module_inst)->e->gc_heap_handle;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gc_heap_handle for AOTModuleInstanceExtra isn't available now, had better comment this line to avoid compile/run error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get~

@wenyongh wenyongh merged commit 7ef782e into bytecodealliance:dev/gc_refactor Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants