Fix ems allocator unaligned memory access on riscv64 #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzzabiyaka
approved these changes
Apr 20, 2023
| /* each hmu node is 4-byte aligned and not 8-byte aligned, | ||
| add 4 bytes padding to make below left/right/parent fields | ||
| 8-byte aligned, so that we can directly access them */ | ||
| uint32 __padding; |
There was a problem hiding this comment.
Hi,
Cannot find where you set this variable but generally very good change for the project as currently ubsan wamr build fails with unaligned access
There was a problem hiding this comment.
Do you mean that before this change, ubsan reports unaligned access issue, and after this PR, the issue isn't reported again? Maybe I should apply the change for all the targets, including x86-64.
There was a problem hiding this comment.
Hi
Now it reports unaligned access but unfortunately I didn't try to fix padding for x86-64 now, and I hope something like that could help
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…e#2140) Make `hmu_tree_node` struct packed and add 4 padding bytes before `kfc_tree_root_buf` field in `gc_heap_struct` struct to ensure the `left/right/parent` fields in `hmu_tree_node` are 8-byte aligned on the 64-bit target which doesn't support unaligned memory access. Fix the issue reported in bytecodealliance#2136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add padding bytes to ensure the left/right/parent fields in struct hmu_tree_node
are 8-byte aligned on the target which doesn't support unaligned memory access.