Avoid re-installing if Tensorflow is already installed for WASI-NN #2148
Conversation
There was a problem hiding this comment.
Please don't use - for file name, use _ instead or CI will report error. How about changing to find_tensorflow_lite.cmake?
There was a problem hiding this comment.
Understood. thank you for the comment
|
@tonibofarull Could you help review the PR? Thanks. |
| ) | ||
| find_path(FLATBUFFER_INCLUDE_DIR | ||
| NAMES flatbuffers/flatbuffers.h | ||
| HINTS ${CMAKE_LIBRARY_PATH}../include |
There was a problem hiding this comment.
I remove it by assuming the user set CMAKE_INCLUDE_PATH (ex. https://github.com/midokura/wasm-micro-runtime/blob/cbaea994e04d7dec48f5bb00c8a54cf1c4e4bdbf/core/iwasm/libraries/wasi-nn/test/Dockerfile.vx-delegate#L89)
|
|
||
| find_library(TENSORFLOW_LITE | ||
| NAMES tensorflow-lite | ||
| HINTS ${CMAKE_LIBRARY_PATH} |
There was a problem hiding this comment.
I remove it by assuming the user set CMAKE_INCLUDE_PATH (ex. https://github.com/midokura/wasm-micro-runtime/blob/cbaea994e04d7dec48f5bb00c8a54cf1c4e4bdbf/core/iwasm/libraries/wasi-nn/test/Dockerfile.vx-delegate#L89)
…ytecodealliance#2148) Since the Tensorflow library is already installed in many cases(especially in the case of the embedded system), move the installation code to find_package.
Since the Tensorflow library is already installed in many cases(especially in the case of the embedded system), move the installation code to find_package.