Fix poll_oneoff, size_t < 8 bytes on some platforms #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
g0djan
commented
Apr 25, 2023
•
g0djan
commented
loganek
reviewed
Apr 25, 2023
| timeout = min(timeout, s->u.u.clock.timeout); | ||
| && (s->u.u.clock.flags & __WASI_SUBSCRIPTION_CLOCK_ABSTIME) == 0 | ||
| && s->u.u.clock.timeout < timeout) { | ||
| timeout = s->u.u.clock.timeout; |
There was a problem hiding this comment.
Good catch; I wonder if other use of min (https://github.com/bytecodealliance/wasm-micro-runtime/pull/2152/files#diff-18a1c12794da572224835cdd9491ff7f93bc7ff81249c75ead3052e7f815f9f8R1021) would potentially be invalid too as it can go over size_t type?
added 2 commits
April 26, 2023 10:57
g0djan
changed the title
loganek
approved these changes
Apr 26, 2023
loganek
approved these changes
Apr 26, 2023
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…platforms (bytecodealliance#2152) According to the 1999 ISO C standard (C99), size_t is an unsigned integer type of at least 16 bit (see sections 7.17 and 7.18.3), it may be uint32 in 32-bit platforms: https://en.cppreference.com/w/cpp/types/size_t Calling function `size_t min(size_t, size_t)` with two uint64 arguments may get invalid result. Co-authored-by: Georgii Rylov <godjan@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.