Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASAN and nightly build to WAMR CI #2161

Merged
merged 1 commit into from
May 26, 2023
Merged

Add ASAN and nightly build to WAMR CI #2161

merged 1 commit into from
May 26, 2023

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Apr 27, 2023 •
edited
Loading

Hi

This CR adds nightly (UTC time) checks with asan and ubsan. Currently, asan works only with aot so adding it for other modes (as well as adding tsan) is tbd.

Also I've put gcc4.8 build to nightly run as I think we don't need to run it with every PR

@eloparco
Copy link
Contributor

eloparco commented May 2, 2023

Are we running tsan with WASI_TEST_OPTIONS? I couldn't find it in the jobs. And I would except that to report errors (coming from wasi-libc).

@wenyongh
Copy link
Contributor

wenyongh commented May 6, 2023

Asking for help with CI in this PR.

If you can take a look and suggest anything that will help to fix this CI issues (see asan and tsan build in github actions) I will really appreciate that.

Also feel free to share you opinion about what the optimization should we use for san build (even -O2 can hide some errors because of compiler optimizations so now it's set to -O0 in testing purposes)

Hi, it may be not so convenient to view the github actions to check the issues reported, and also it is complex to resolve all the issues for both asan and tsan. I think we had better file new issues to provide more details (e.g. one issue for asan and the other for tsan, list some errors reported and describe how to reproduce them), and then others can discuss and check how to resolve the issues one by one.

@Zzzabiyaka Zzzabiyaka force-pushed the main branch 3 times, most recently from 483664d to 747330d Compare May 9, 2023 15:46
@Zzzabiyaka Zzzabiyaka marked this pull request as draft May 9, 2023 15:49
@Zzzabiyaka Zzzabiyaka force-pushed the main branch 2 times, most recently from 79c371d to ede3bd3 Compare May 9, 2023 17:02
@Zzzabiyaka Zzzabiyaka force-pushed the main branch 7 times, most recently from 68831e8 to a743bbc Compare May 15, 2023 21:41
@Zzzabiyaka Zzzabiyaka force-pushed the main branch 13 times, most recently from 35a3a32 to 5142d7a Compare May 22, 2023 12:14
wenyongh
wenyongh reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us
Copy link
Collaborator

LGTM

loganek
loganek approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few minor comments though.

wenyongh
wenyongh reviewed May 24, 2023
View reviewed changes
core/iwasm/common/wasm_runtime_common.c Outdated Show resolved Hide resolved
core/iwasm/interpreter/wasm_interp_classic.c Outdated Show resolved Hide resolved
core/shared/platform/common/posix/posix_thread.c Outdated Show resolved Hide resolved
@Zzzabiyaka Zzzabiyaka force-pushed the main branch 12 times, most recently from f9939d8 to a797364 Compare May 24, 2023 14:58
wenyongh
wenyongh reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 2723972 into bytecodealliance:main May 26, 2023
@Zzzabiyaka Zzzabiyaka mentioned this pull request Jun 1, 2023
Open
@Zzzabiyaka Zzzabiyaka mentioned this pull request Oct 30, 2023
Merged
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@Zzzabiyaka
Add asan and ubsan to WAMR CI (bytecodealliance#2161)
546f3b7 
Add nightly (UTC time) checks with asan and ubsan, and also put gcc-4.8 build
to nightly run since we don't need to run it with every PR.

Co-authored-by: Maksim Litskevich <makslit@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us left review comments

@eloparco eloparco eloparco left review comments

@wenyongh wenyongh wenyongh left review comments

@loganek loganek loganek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zzzabiyaka @eloparco @wenyongh @lum1n0us @loganek