Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMSIS import with Zephyr 3.4+ #2744

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix CMSIS import with Zephyr 3.4+ #2744

merged 1 commit into from
Nov 10, 2023

Conversation

hasheddan
Copy link
Contributor

Fixes the import path for CMSIS in Zephyr versions > 3.4.

See zephyrproject-rtos/zephyr#59855 for more information.

@hasheddan
Fix CMSIS import with Zephyr 3.4+
1f366fe 
Fixes the import path for CMSIS in Zephyr versions > 3.4.

See zephyrproject-rtos/zephyr#59855 for more
information.

Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
wenyongh
wenyongh reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 314ecba into bytecodealliance:main Nov 10, 2023
374 checks passed
@srberard
Copy link
Contributor

srberard commented Nov 13, 2023 •
edited
Loading

I'm hitting this error still. If I explicitly checkout 314ecba, it works. However, if I checkout main I hit the above error. According to the details above, this was merged 4 days ago. I've confirmed that I have the latest changes pulled down so I'm not sure why this is still failing. It's not urgent as I can use the specific commit for the moment.

@hasheddan
Copy link
Contributor Author

@srberard it could be related to #2760, which I am working on fixing 👍🏻

@wenyongh
Copy link
Contributor

@srberard @hasheddan please refer to #2777

victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@hasheddan
Fix CMSIS import with Zephyr 3.4+ (bytecodealliance#2744)
78f20ee 
Fixes the import path for CMSIS in Zephyr versions > 3.4.

See zephyrproject-rtos/zephyr#59855 for more
information.

Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasheddan @srberard @wenyongh